Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simapp to nightly-2020-07-29 #323

Merged
merged 9 commits into from
Aug 4, 2020
Merged

Update simapp to nightly-2020-07-29 #323

merged 9 commits into from
Aug 4, 2020

Conversation

webmaster128
Copy link
Member

This uses the latest previewof the simapp docker image. See cosmos/cosmos-sdk#6517

@tac0turtle
Copy link
Member

tac0turtle commented Jul 29, 2020

pushing to interchainio right now, so you should be able to point there

EDIT: https://hub.docker.com/layers/interchainio/simapp/nightly-2020-07-29/images/sha256-914c0195ecc950d6bd907733e0f0af4feb4412a6728b73ca19bcd096be2b8b99?context=explore

@webmaster128
Copy link
Member Author

We now get CI fails in the coverage step because the chain creates files owned by root in ./scripts/simapp. We don't have this problem with wasmd because all data is mounted into a volume:

  --mount type=bind,source="$SCRIPT_DIR/template",target=/template \
  --mount type=volume,source=wasmd_data,target=/root \

instead of

  --mount type=bind,source="$SCRIPT_DIR/template",target=/root \

Let's see if we can do the same here.

@tac0turtle
Copy link
Member

would you want an image that is tagged as latest, that way you don't have to keep updating? although then you could get daily breakage.

@webmaster128
Copy link
Member Author

would you want an image that is tagged as latest, that way you don't have to keep updating?

No thank you. We can update the backend once in a while or even daily, no problem. For me reproducibility is more important than simplicity. You also want the same behaviour locally and in the CI. Having to docker pull is annoyingly slow and docker run ...:latest will not update the image if you have any version of the latest tag.

@webmaster128 webmaster128 marked this pull request as ready for review August 2, 2020 19:17
@webmaster128 webmaster128 merged commit c3f6a38 into master Aug 4, 2020
@webmaster128 webmaster128 deleted the simapp-update branch August 4, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants